[Buildroot] [PATCH v2] Add patch to fix linking issue

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Aug 18 12:13:55 UTC 2015


Dear Simon Marchi,

On Mon, 10 Aug 2015 16:37:55 -0400, Simon Marchi wrote:
> This patch fixes this autobuild failure:
> 
>   http://autobuild.buildroot.net/results/e14/e14e1700d4fe359c56be57587bdb509e002e5753/build-end.log
> 
> The problem is caused by the -fvisibility-inlines-hidden switch.
> Removing the switch is probably the least intrusive way we can make the
> problem go away.  The first solution that was considered was to move the
> definition of the offending method to the .cpp file.  However, with
> other combinations of compilers and platforms, I suppose it could happen
> with other methods as well.  Removing the switch ensures we catch them
> all.
> 
> Built-tested with the config from the build bot, as well as with all OLA
> options/plugins enabled.
> 
> Signed-off-by: Simon Marchi <simon.marchi at polymtl.ca>

The title of the patch should be:

	ola: add patch to fix linking issue

> diff --git a/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch b/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch
> new file mode 100644
> index 0000000..ac087f4
> --- /dev/null
> +++ b/package/ola/0001-Remove-fvisibiliy-inlines-hidden.patch
> @@ -0,0 +1,25 @@
> +From c160119ff3ff595862e7ba2a7b8bcb3302f13f02 Mon Sep 17 00:00:00 2001
> +From: Simon Marchi <simon.marchi at polymtl.ca>
> +Date: Mon, 10 Aug 2015 15:01:42 -0400
> +Subject: [PATCH] Remove -fvisibiliy-inlines-hidden
> +

Missing Signed-off-by here.

Can you respin after fixing those issues?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list