[Buildroot] [PATCH 1/3] [v3] libgudev: New package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Aug 25 18:48:33 UTC 2015


Nathaniel,

On Mon, 24 Aug 2015 23:44:14 +0800, Nathaniel Roach wrote:
> As libgudev recently was split from the main systemd/udev source,
> 	this library is now required to build certain packages.
> 
> This library is only relevant to systemd, as the code it contains
> 	is still contained in eudev.
> 
> Add the package and tweak systemd's Config.in message accordingly.
> 
> ---
> Changes v2 -> v3
> (Changes as suggested by Yann E. MORIN)
>  - Separate libgudev and network-manager portions into
> 	discrete patches, and a new patch for libmbim

Applied after doing a few changes:

    [Thomas:
     - don't show the dependency comment when systemd is not available,
       since libgudev is anyway useless when you're not using systemd.
     - fix the license, it's LGPLv2.1+ and not GPLv2+
     - remove useless empty lines in the .mk file.]

In addition to this, two comments:

 * Your SoB line should be before the first "---". Otherwise, it gets
   removed by git when applying the patch (anything after the first
   "---" gets ignored by git in terms of commit log)

 * Don't indent the second line of paragraphs with a tab, we don't do
   this in general for Buildroot commit logs.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list