[Buildroot] [PATCH 1/2 v2] autotools-package: also handle pre-installed external toolchain in .la fixup

Peter Korsgaard peter at korsgaard.com
Mon May 4 13:35:31 UTC 2015


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > From: Arnout Vandecappelle <arnout at mind.be>
 > The .la fixup handling looks for paths starting with /usr and assumes
 > that they are missing the installation prefix (i.e. $(STAGING_DIR)). It
 > already handles the cases that $(STAGING_DIR) itself and $(BASE_DIR)
 > are under /usr, but it does not yet handle the case that a
 > pre-installed external toolchain is under /usr (and tracks that fact
 > in some .la file). For instance, if you use buildroot to generate a
 > toolchain with HOST_DIR=/usr/local/some_path, this problem will occur.

 > Fix this in the same way as $(STAGING_DIR) and $(BASE_DIR), but in
 > addition check that TOOLCHAIN_EXTERNAL_INSTALL_DIR is non-empty. For
 > internal toolchains, it is empty and the sed expression would fail.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
 > Reported-by: Carlos Soto <csotoalonso at gmail.com>
 > Cc: Carlos Soto <csotoalonso at gmail.com>
 > Reviewed-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998 at free.fr>

 > ---
 > I haven't been able to test this very extensively because it's not so
 > easy to find .la files where it goes wrong.

 > Carlos, can you check if this patch solves the problem for you?

Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list