[Buildroot] [PATCH 1/1] Fix mkfs.jffs2 --pagesize parameter usage.
Peter Korsgaard
peter at korsgaard.com
Fri May 22 09:34:45 UTC 2015
>>>>> "Michał" == Michał Leśniewski <mlesniew at gmail.com> writes:
> This fixes bug 8186 on Bugzilla.
> The mkfs.jffs2 accepts a --pagesize parameter, which allows specifying
> the size of the virtual memory page size of the target machine, where
> the image will be used. (This is the value of the PAGE_SIZE macro in
> Linux.) In most cases the parameter doesn't need to be set as the
> default value of 4 kB is usually correct.
> The parameter was used incorrectly in Buildroot -- it was set to the
> page size of flash memory chip -- this commit fixes this problem. Now
> the --pagesize parameter is not used at all (unless the user explicitly
> chooses to use a custom value during configuration). All defconfigs existing
> defconfigs were corrected to match the new configuration variable names.
> Signed-off-by: Michał Leśniewski <mlesniew at gmail.com>
Thanks, committed with a slightly reworded commit message and
Config.in.legacy handling for the renamed symbols.
> +config BR2_TARGET_ROOTFS_JFFS2_USE_CUSTOM_PAGESIZE
> + bool "Select custom virtual memory page size"
> + default false
NIT: bool symbols default to false, so this line isn't needed.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list