[Buildroot] ALSA for build root Part 2

Wed Jun 6 07:47:37 UTC 2007

On Wed, 2007-05-30 at 23:29 +0100, Rod Boyce wrote:
> Bernhard Fischer wrote:
> > On Tue, May 29, 2007 at 09:03:12AM +0200, Hans-Christian Egtvedt wrote:

<cut>

> Attached is an updated patch that does not offend the sensibilities of 
> other ALSA people working on build root.  This is just alsa-lib and 
> alsa-utils I will send out a patch for more alsa stuff latter.  This 
> outputs to $(STAGING_DIR)/usr/lib which on my build happens to be a link 
> back to $(STAGING_DIR)/lib. 

Same here, AFAIK it is supposed to be that way.

> I have also removed the device links that I 
> was putting in the dev directory I had not removed this since I switched 
> over to udev.  Just --prefix=/usr did not fix all paths all of the time 
> although I think that I have the minimum custom options for configure 
> and install targets for both utilities and library makefile fragments 
> now.

Weird, what prefixes are not correct? I only have to give --prefix=/usr
and --sysconfdir=/etc .

> I also figured out what the "basename nonsense" was and while I 
> approve of the intent I used a more makefile way of doing the same thing.
> 
> Hopefully this is a more acceptable patch, if anybody has some more 
> suggestions then perhaps they would like to contribute their own ALSA 
> patch's so we can either pick the best or merge and get the best of both 
> worlds and produce a better build-root system.

Comments below.

> diff -uN --recursive ../trunk/package/alsa-lib/alsa-lib.mk
> package/alsa-lib/alsa-lib.mk
> --- ../trunk/package/alsa-lib/alsa-lib.mk       1970-01-01
> 01:00:00.000000000 +0100
> +++ package/alsa-lib/alsa-lib.mk        2007-05-30 22:58:14.604803783
> +0100
> @@ -0,0 +1,95 @@
> +#############################################################
> +#
> +# ALSA library
> +#
> +#############################################################
> +
> +ALSA-LIB_VERSION := 1.0.14rc4

Same as for alsa-tools, I prefer the ALSA_LIB_VERSION, all underscores.

> +ALSA-LIB_SOURCE := alsa-lib-$(ALSA-LIB_VERSION).tar.bz2
> +ALSA-LIB_SITE := ftp://ftp.alsa-project.org/pub/lib/
> +ALSA-LIB_DIR := $(BUILD_DIR)/$(patsubst %.tar.bz2,%,$(ALSA-LIB_SOURCE))

Again, I prefer the all written approach, to easier see what the
variable is.

> +ALSA-LIB_CAT := $(BZCAT)
> +ALSA-LIB_PATH := /usr/lib

usr/lib, skip leading /

> +ALSA-LIB_DEBUG := yes
> +ifneq ($(BR2_PACKAGE_ALSA-LIB_DEBUG_ENABLE),y)
> +ALSA-LIB_DEBUG := no
> +endif

Nice, but better to set them as "--with-debug" or "--without-debug" and
append them to the ./configure.

> +$(DL_DIR)/$(ALSA-LIB_SOURCE):
> +       $(WGET) -P $(DL_DIR) $(ALSA-LIB_SITE)/$(ALSA-LIB_SOURCE)
> +
> +$(ALSA-LIB_DIR)/.unpacked: $(DL_DIR)/$(ALSA-LIB_SOURCE)
> +       $(ALSA-LIB_CAT) $(DL_DIR)/$(ALSA-LIB_SOURCE) | tar -C
> $(BUILD_DIR) $(TAR_OPTIONS) -
> +       touch $@
> +
> +$(ALSA-LIB_DIR)/.configured: $(ALSA-LIB_DIR)/.unpacked
> +       (cd $(ALSA-LIB_DIR); rm -rf config.cache; \
> +               $(TARGET_CONFIGURE_OPTS) \
> +               ./configure \
> +               --target=$(GNU_TARGET_NAME) \
> +               --host=$(GNU_TARGET_NAME) \
> +               --build=$(GNU_HOST_NAME) \
> +               --prefix=/usr \
> +               --sysconfdir=/etc \
> +               --libdir=$(ALSA-LIB_PATH) \

This should be set with the prefix, not needed.

Add the ALSA-LIB_DEBUG variable.

> +               --disable-docs \
> +               --with-debug=$(ALSA-LIB_DEBUG) \
> +               $(DISABLE_NLS) \
> +       );
> +       touch $@
> +
> +$(ALSA-LIB_DIR)/src/libasound.la: $(ALSA-LIB_DIR)/.configured
> +       rm -f $@
> +       $(MAKE) CFLAGS=-g CC=$(TARGET_CC) -C $(ALSA-LIB_DIR)

Only append -g if you actually are making debug target, see comment on
debug option further up.

> +$(STAGING_DIR)$(ALSA-LIB_PATH)/libasound.so.2.0.0:
> $(ALSA-LIB_DIR)/src/libasound.la
> +       $(MAKE) prefix=$(STAGING_DIR) \
> +           exec_prefix=$(STAGING_DIR) \
> +           libdir=$(STAGING_DIR)$(ALSA-LIB_PATH) \
> +           -C $(ALSA-LIB_DIR) install;
> +       @touch -c $@
> +
> +$(TARGET_DIR)$(ALSA-LIB_PATH)/libasound.so.2.0.0:
> $(STAGING_DIR)$(ALSA-LIB_PATH)/libasound.so.2.0.0
> +       @mkdir -p $(TARGET_DIR)/usr/share/alsa
> +       @mkdir -p $(TARGET_DIR)$(ALSA-LIB_PATH)/alsa-lib/smixer