[Buildroot] [RFC/PATCH 1/3] fix buildroot sed handling on Mac OS X

Heikki Lindholm holindho at cs.helsinki.fi
Thu Mar 8 21:36:22 UTC 2007

Bernhard Fischer kirjoitti:
> On Sun, Feb 25, 2007 at 01:22:38PM +0200, Heikki Lindholm wrote:
>>Improve the checking of sed by adding some common GNU sed installation
>>names (gsed/gnused), checking for a basic OS X sed feature in command
>>line option handling, checking the actual result of the sed run against
>>the expected result, and placing common code for the check under
>>-- Heikki Lindholm
>>diff -Nru buildroot/package/sed/sedcheck.sh buildroot-devel/package/sed/sedcheck.sh
>>--- buildroot/package/sed/sedcheck.sh	2007-02-22 10:50:29.000000000 +0200
>>+++ buildroot-devel/package/sed/sedcheck.sh	2007-02-23 17:39:04.000000000 +0200
>>@@ -2,24 +2,10 @@
>># Make sure the host sed supports '-i' (in-place).
>># If it doesn't, we'll build and use our own.
>>-if test -x /usr/bin/sed ; then
>>-	SED="/usr/bin/sed"
>>-	if test -x /bin/sed ; then
>>-		SED="/bin/sed"
>>-	else
>>-		SED="sed"
>>-	fi
>>-echo "HELLO" > .sedtest
>>-$SED -i -e "s/HELLO/GOODBYE/" .sedtest >/dev/null 2>&1
> Why don't you mv check-host-sed.sh here instead and use it in
> dependencies.sh? I'd prefer it this way..

Well. I tossed a coin on the placement. I thought checking the host sed 
would belong better to something build-framework-ish than the sed 
package. I'll do a respin of this if you like.

-- Heikki Lindholm

More information about the buildroot mailing list