[Buildroot] svn commit: trunk/buildroot/target/linux

Jean-Christian de Rivaz jc at eclis.ch
Tue Apr 15 21:09:04 UTC 2008


Ulf Samuelsson a écrit :
> 
>> Ulf Samuelsson a écrit :
>>> ----- Original Message ----- 
>>> From: "Jean-Christian de Rivaz" <jc at eclis.ch>
>>> To: <buildroot at uclibc.org>
>>> Cc: <ulf at uclibc.org>
>>> Sent: Tuesday, April 15, 2008 7:43 PM
>>> Subject: Re: [Buildroot] svn commit: trunk/buildroot/target/linux
>>>
>>>
>>>> ulf at uclibc.org a écrit :
>>>>> Author: ulf
>>>>> Date: 2008-04-15 10:10:24 -0700 (Tue, 15 Apr 2008)
>>>>> New Revision: 21739
>>>>>
>>>>> Log:
>>>>> Reversing bad tftpboot patch resulting in two identical targets
>>>>>
>>>>> Modified:
>>>>>    trunk/buildroot/target/linux/Makefile.in.advanced
>>>> Ouch! Can you please explain why did you re-introduce this bug ?
>>>> The BR2_LINUX_COPYTO variable have absolutely no way to work with a hard 
>>>> coded "/tftpboot/". Just try to copy to /var/lib/tftpboot for example.
>>> Because it is not a bug.
>>>
>>> The Configuration now allows you to
>>>
>>> 1) Copy to /tftpboot                                (if BR2_LINUX_COPYTO_TFTPBOOT is set)
>>> 2) Copy to $(BR2_LINUX_COPYTO)    (if BR2_LINUX_COPYTO is non-empty)
>>>
>>> Before the patch you would have (a little simplified)
>>>
>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>> LINUX_COPYTO:=BR2_LINUX_COPYTO
>>>
>>> $(BR2_LINUX_COPYTO)/$(LINUX26_KERNEL_NAME): $(LINUX26_KERNEL)
>>>         mkdir -p $(BR2_LINUX_COPYTO)
>>>         cp -dpf $(LINUX26_KERNEL) $(BR2_LINUX_COPYTO)/$(LINUX26_KERNEL_NAME)
>>>
>>> $(LINUX_COPYTO)/$(LINUX26_KERNEL_NAME): $(LINUX26_KERNEL)
>>>         mkdir -p $(LINUX_COPYTO)
>>>         cp -dpf $(LINUX26_KERNEL) $(LINUX_COPYTO)/$(LINUX26_KERNEL_NAME)
>>> --------------------------------------------------------------------------------------------------
>>>
>>> Since LINUX_COPYTO is identical to BR2_LINUX_COPYTO you 
>>> have two IDENTICAL rules, which makes no sense.
>>>
>>> If you want to copy to "/var/lib/tftpboot" your .config should contain:
>>>
>>> BR2_LINUX_COPYTO_TFTPBOOT=n
>>> BR2_LINUX_COPYTO="/var/lib/tftpboot"
>> Ok, I understand your point now, but I still maintain that hardcoded 
>> "/tftpboot" is not a solution for this problem, because on many systems 
>> there is no "/tftpboot" in the root filesystem, because the users don't
>> have the right to create it, and because new distributions use 
>> /var/lib/tftpboot instead of /tftpboot.
>>
> 
> If you cannot use "/tftpboot" then don't use it!
> 
> The purpose of BR2_LINUX_COPYTO is to allow people
> to copy to any directory of their choice and this includes "/var/lib/tftpboot".
> 
> I have told you how to configure buildroot to do the copy the files to where you want.
> 
> Please change your configuration files and get on with other things.

Why not simply removing BR2_LINUX_COPYTO_TFTPBOOT and set by default 
BR2_LINUX_COPYTO="/tftpboot" ? Peoples that wants to copy elsewhere can 
simply change BR2_LINUX_COPYTO according to there setup.

This will simplify the whole things without losing any possibility.

-- 
Jean-Christian de Rivaz



More information about the buildroot mailing list