[Buildroot] [PATCH] qtopia4: fix wrong variable name for SQL

Markus Heidelberg markus.heidelberg at web.de
Sat Nov 1 11:09:01 UTC 2008


Thiago A. Corrêa, 31.10.2008:
> Thanks.
> Applied in r23872.
> 
> Btw, could you send patches as attachments (instead or as well)? Not
> sure how others prefers them,

I prefer inline patches, for easier commenting for example. I also find
attachments are quite annoying if I have to use the web archives and can't
just read the patch but have to download it at first. I know Peter prefers
inline for the ease of applying them with "git am" and he has already applied
a few from me.

> but since I don't view my mail on linux
> boxes and only use linux through ssh I sort of have to apply them by
> typing it back on the ssh window.

What are the advantages of using attachments or the disadvantages of inline
through your ssh connection? When you are able to save an attachment you can
also just save the whole email and apply it, can't you?

> Also, I don't trust copy and paste
> to not mess with the whitespaces and tabs.... If I do mess them up
> others jump on my neck. Whitespace damage is sort of worst than having
> a non working package around here *smile*.

If whitespace is damaged after copy and paste, you will notice it when
applying the malformed patch.

Markus




More information about the buildroot mailing list