[Buildroot] [PATCH 5/9] Refactor invocation of make for kernel compiles

[Grant Likely]

On Thu, Oct 16, 2008 at 3:55 PM, Markus Heidelberg
<markus.heidelberg at web.de> wrote:
> Grant Likely, 16.10.2008:
>>
>> -     $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) modules
>> -     $(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) \
>> +     $(LINUX26_MAKE) modules
>> +     $(LINUX26_MAKE) \
>>               DEPMOD=$(STAGING_DIR)/bin/$(GNU_TARGET_NAME)-depmod26 \
>>               INSTALL_MOD_PATH=$(TARGET_DIR) modules_install
>
> DEPMOD could be defined in LINUX26_MAKE_FLAGS, INSTALL_MOD_PATH is already
> there. Then it would be a small line here.

Yes, that makes sense.  fixed.

>> @@ -240,6 +242,9 @@ linux26-force:
>>  # This has been renamed so we do _NOT_ by default run this on 'make clean'
>>  linux26clean:
>>       rm -f $(LINUX26_KERNEL) $(LINUX26_DIR)/.configured
>> +     # Note; this invocation of make is different from the rest.  Why
>> +     # does 'PATH' need to be assigned here?  Can this be replaced with
>> +     # $(LINUX26_MAKE) like all the others?
>>       -$(MAKE) PATH=$(TARGET_PATH) -C $(LINUX26_DIR) clean
>
> I think so, maybe a leftover, but I don't know. Git-grepping for TARGET_PATH
> through the repository shows some uses of this in 4 devices but not restricted
> to the clean target.

I've just tried this, and it seems to work.  Next version of this
patch will have this like look like all the rest.  I'll wait another
day or so for more comments and then repost.

Thanks,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.