[Buildroot] [PATCH] optional DBus support in wpa_supplicant
s.neumann at raumfeld.com
Wed Jul 15 08:11:30 UTC 2009
On Tue, 2009-07-14 at 21:20 +0200, Peter Korsgaard wrote:
> Sven> --- ../buildroot-orig/package/wpa_supplicant/wpa_supplicant.mk 2009-07-12 21:13:04.000000000 +0200
> Sven> +++ package/wpa_supplicant/wpa_supplicant.mk 2009-07-13 11:07:52.000000000 +0200
> Sven> @@ -13,10 +13,14 @@
> Sven> WPA_SUPPLICANT_CONFIG = $(WPA_SUPPLICANT_DIR)/wpa_supplicant/.config
> Sven> WPA_SUPPLICANT_SUBDIR = wpa_supplicant
> Sven> WPA_SUPPLICANT_TARGET_BINS = wpa_cli wpa_supplicant wpa_passphrase
> Sven> +WPA_SUPPLICANT_DBUS_SERVICE = fi.epitest.hostap.WPASupplicant
> Aren't you missing a ".service" here? Service files seems to normally
> have the .service extension, and the wpa supplicant file on my machine
> (Debian) does as well.
> Sven> + $(INSTALL) -D \
> Sven> + $(WPA_SUPPLICANT_DIR)/wpa_supplicant/dbus-wpa_supplicant.service \
> Sven> + $(TARGET_DIR)/usr/share/dbus-1/system-services/$(WPA_SUPPLICANT_DBUS_SERVICE)
> Here you don't add it
> Sven> + rm -f $(TARGET_DIR)/usr/share/dbus-1/system-services/$(WPA_SUPPLICANT_DBUS_SERVICE).service
> But here you do.
Yes, the suffix is missing there. I didn't actually use the DBus
activation feature that relies on this file. So I didn't notice that I
got the filename wrong. Well spotted.
More information about the buildroot