[Buildroot] [RFC] Package infrastructure: make variables or make targets ?

[H Hartley Sweeten]

On Thursday, October 29, 2009 8:39 AM, Thomas Petazzoni wrote:
> I have one naming issue in the generic package infrastructure
> (package/Makefile.package.in) on which I'd like to get your input. The
> generic package infrastructure let the package specific .mk file
> specify what the configure, build and install steps should do, by
> defining variables :
> 
>  <PKG>_CONFIGURE for configure
>  <PKG>_BUILD for build
> 
> for installation, I wanted to use
> 
>  <PKG>_INSTALL_STAGING for staging installation
>  <PKG>_INSTALL_TARGET for target installation
> 
> but these variables are already existing boolean variables (YES/NO)
> that allows the package to specify whether it wants TARGET installation
> and/or STAGING installation. So we have a naming conflict, that I
> solved by using
> 
>  <PKG>_INSTALL_STAGING_CMDS
>  <PKG>_INSTALL_TARGET_CMDS
> 
> for the variables that a package specific .mk must define to list the
> operations to be performed at staging install and target install. But I
> don't like this naming since it isn't coherent with <PKG>_CONFIGURE and
> <PKG>_BUILD.
> 
> Any suggestion ?

How about changing the boolean variables to:

<PKG>_STAGING_INSTALL to indicate a STAGING installation is wanted
<PKG>_TARGET_INSTALL to indicate a TARGET installation is wanted

Then you can use:

<PKG>_INSTALL_STAGING for staging installation
<PKG>_INSTALL_TARGET for target installation

Regards,
Hartley