[Buildroot] [PATCH 4/5] Remove BR2_TOPDIR_PREFIX and BR2_TOPDIR_SUFFIX
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Thu Sep 10 06:30:10 UTC 2009
Hi Bernhard,
Thanks for your comments!
Le Wed, 9 Sep 2009 19:35:35 +0200,
Bernhard Reutner-Fischer <rep.dot.nop at gmail.com> a écrit :
Le Wed, 9 Sep 2009 19:35:35 +0200,
Bernhard Reutner-Fischer <rep.dot.nop at gmail.com> a écrit :
> 1) COND_ARCH_FPU_SUFFIX is _completely_ useless, to say the least.
This one is removed by PATCH 5/5.
> 2) TOPDIR_PREFIX and TOPDIR_SUFFIX don't hurt and are convenient for
> some corner-cases. I'd keep them.
As they don't provide any additional value over O=, I'd prefer to keep
O=. One of the reason for which Buildroot is too complicated today is
because there are multiple ways of achieving the same thing. This
multitude of options is confusing for newcomers.
> 3) I'd much prefer if we could
> rather settle on
> TOOL_BUILD_DIR=$(BASE_DIR)/$(TOPDIR_PREFIX)$(ARCH)$(ARCH_FPU_SUFFIX)$(ARCH_MMU_SUFFIX)$(TOPDIR_SUFFIX)_toolchain
> BUILD_DIR
> =$(BASE_DIR)/$(TOPDIR_PREFIX)$(ARCH)$(ARCH_FPU_SUFFIX)$(ARCH_MMU_SUFFIX)$(TOPDIR_SUFFIX)_build
>
> so you can conveniently rm -rf powerpc_nofpu_* (for example)
See PATCH 5/5, these are completely changed to something else.
Sincerly,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list