[Buildroot] [PATCH 03/21] udpcast: convert to the autotools infrastructure

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Apr 13 14:59:03 UTC 2010


Hello,

On Mon, 12 Apr 2010 19:48:49 +0200
Peter Korsgaard <jacmet at uclibc.org> wrote:

>  Thomas> +UDPCAST_CONF_ENV = ac_cv_type_stat64=yes
> 
>  Thomas> -		$(if
>  Thomas> $(BR_LARGEFILE),ac_cv_type_stat64=yes,ac_cv_type_stat64=no) \
> 
> Why are you now forcing 64bit here?

Good question. When I wrote the change, I remember thinking about this,
but I really don't remember why I did the change this way. Definitely,
we should be conservative and keep it as it was.

> Not a big deal, but you seem to forgot the final newline in several
> files - Is there any reason why?

Simply because in the text editor I'm using, having a final newline or
not does not make any visible difference, so I always forget about this.

I've pushed updated versions of the patches, to fix the udpcast large
file thing, and to add the newlines at the end of files. You can pull
from:

 git://git.busybox.net/~tpetazzoni/git/buildroot autotools-conversion

I'm not spamming again the list by resending everything, but if you
think it's worth, I'll do so.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list