[Buildroot] [PATCH v2] rsh-redone: new package for rsh/rlogin clients

Peter Korsgaard jacmet at uclibc.org
Tue Dec 7 21:20:31 UTC 2010


>>>>> "Mike" == Mike Frysinger <vapier at gentoo.org> writes:

 Mike> On Tuesday, December 07, 2010 06:07:26 Peter Korsgaard wrote:
 Mike> +# requires PAM
 Mike> +#config BR2_PACKAGE_RSH_REDONE_RSHD
 Mike> +#	bool "rshd"
 Mike> +#	depends on BR2_PACKAGE_RSH_REDONE
 >> 
 >> How useful is this without the server part?

 Mike> i use rshd from inetutils.  ive never tested rshd from this since
 Mike> it requires pam (as already documented).  someone else can if
 Mike> they care.

Ok.

 >> Does this do anything else than just copying the binaries? If not, it
 >> might be simpler to just do a
 >> 
 >> for i in $(rsh-redone-bin-y); do $(INSTALL) -m 755 -D $$i
 >> $(TARGET_DIR)/usr/bin/$$i; done for i in $(rsh-redone-sbin-y); do
 >> $(INSTALL) -m 755 -D $$i $(TARGET_DIR)/usr/sbin/$$i; done

 Mike> i prefer to let the package build system do these simple steps to
 Mike> avoid worrying about changes in between version bumps.  this
 Mike> proposal for examples misses set*id on the binaries, and i'm not
 Mike> entirely sure it is more simple.

setuid/setgid wouldn't work anyway, as we don't do make install as
root. For that kind of stuff you have to define it in device_table.txt
like it's done for busybox.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list