[Buildroot] [PATCH 1/3] Add libxpm as a dependency of ace_of_penguins

Peter Korsgaard jacmet at uclibc.org
Fri Feb 19 10:12:28 UTC 2010


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 Thomas> ace_of_penguins fails to build when xlib_libXpm is not selected. Add
 Thomas> it has a dependency. However, contrary to normal dependencies to
 Thomas> libraries (where we use 'select') we use 'depends on' here, otherwise
 Thomas> the X.org server will be get selected automatically without the user
 Thomas> noticing.

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 Thomas> ---
 Thomas>  package/games/ace_of_penguins/Config.in          |    1 +
 Thomas>  package/games/ace_of_penguins/ace_of_penguins.mk |    2 +-
 Thomas>  2 files changed, 2 insertions(+), 1 deletions(-)

 Thomas> diff --git a/package/games/ace_of_penguins/Config.in b/package/games/ace_of_penguins/Config.in
 Thomas> index edbaf26..1d5a367 100644
 Thomas> --- a/package/games/ace_of_penguins/Config.in
 Thomas> +++ b/package/games/ace_of_penguins/Config.in
 Thomas> @@ -2,6 +2,7 @@ config BR2_PACKAGE_ACE_OF_PENGUINS
 Thomas>  	bool "ace_of_penguins"
 Thomas>  	select BR2_PACKAGE_LIBPNG
 Thomas>  	depends on BR2_PACKAGE_XORG7
 Thomas> +	depends on BR2_PACKAGE_XLIB_LIBXPM

But we already depend on XORG7, so selecting LIBXPM seems ok to me?
Longer term we should certainly make it possible to build X stuff
without also building a X server.


-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list