[Buildroot] [git commit master 1/1] Makefile.package.in: allow packages to override download step

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Jul 1 16:04:47 UTC 2010


Hello,

On Thu, 1 Jul 2010 17:33:29 +0200
Peter Korsgaard <jacmet at sunsite.dk> wrote:

> diff --git a/package/Makefile.package.in b/package/Makefile.package.in
> index 16ce16a..c476de9 100644
> --- a/package/Makefile.package.in
> +++ b/package/Makefile.package.in
> @@ -292,7 +292,7 @@ $(2)_TARGET_BUILD =
> $$($(2)_DIR)/.stamp_built $(2)_TARGET_CONFIGURE =
> $$($(2)_DIR)/.stamp_configured $(2)_TARGET_PATCH =
> $$($(2)_DIR)/.stamp_patched $(2)_TARGET_EXTRACT =
> $$($(2)_DIR)/.stamp_extracted -$(2)_TARGET_SOURCE =
> $$($(2)_DIR)/.stamp_downloaded +$(2)_TARGET_SOURCE ?=
> $$($(2)_DIR)/.stamp_downloaded $(2)_TARGET_UNINSTALL =
> $$($(2)_DIR)/.stamp_uninstalled $(2)_TARGET_CLEAN =
> $$($(2)_DIR)/.stamp_cleaned $(2)_TARGET_DIRCLEAN =
> $$($(2)_DIR)/.stamp_dircleaned

As said on IRC, I'm sorry but I don't think I really like this.

We already have a mechanism to override steps in Makefile.autotools.in.
I'd prefer to see if we can rely on a similar mechanism rather than
doing this.

In the future, is it possible to discuss such infrastructure changes on
the list beforehand ?

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list