[Buildroot] [PATCH 3/4] ffmpeg: allow customization of codecs, (de)muxers and other components

Luca Ceresoli luca at lucaceresoli.net
Mon Jun 14 08:50:30 UTC 2010


Peter Korsgaard wrote:
> >>>>> "Luca" == Luca Ceresoli <luca at lucaceresoli.net> writes:
> 
>  Luca> Add the option to customize the list of decoders, encoders,
>  Luca> muxers, demuxers, parsers, protocols, bsfs and filters to be
>  Luca> built into ffmpeg, and to compile or exclude input and output
>  Luca> devices.
> 
>  Luca> +++ b/package/multimedia/ffmpeg/ffmpeg.mk
>  Luca> @@ -49,6 +49,58 @@ else
>  Luca>  FFMPEG_CONF_OPT += --disable-ffserver
>  Luca>  endif
>  
>  Luca> +ifneq ($(BR2_PACKAGE_FFMPEG_ENCODERS),"all")
>  Luca> +FFMPEG_CONF_OPT += --disable-encoders \
>  Luca> +	$(foreach x,$(call qstrip,$(BR2_PACKAGE_FFMPEG_ENCODERS)),--enable-encoder=$(x))
>  Luca> +endif
>  Luca> +
>  Luca> +ifneq ($(BR2_PACKAGE_FFMPEG_DECODERS),"all")
> 
> I would suggest you use qstrip + strip here as well, so it doesn't break if the
> user accidently added extra spaces or so.

How can foreach break with extra spaces? I've been trying things as:
> BR2_PACKAGE_FFMPEG_ENCODERS="   vorbis    flac  "
and they work ok.

BTW, that was with GNU make. Relevant?

> 
> -- 
> Bye, Peter Korsgaard
> 

Luca





More information about the buildroot mailing list