[Buildroot] [PATCH v2] package: add opencv

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Aug 18 12:34:28 UTC 2011


Hello,

Thanks for this new version, looks much better.

Le Thu, 18 Aug 2011 07:32:16 +0200,
Samuel Martin <s.martin49 at gmail.com> a écrit :

> +HOST_OPENCV_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENCV_BUILD_NEW_PYTHON_SUPPORT),host-python,)

Why do you need a host version of OpenCV ? I don't see where the
host-opencv package is being used.

Also, just a matter of taste, but I would prefer if you grouped
together the OPENCV_CONF_OPT += and OPENCV_DEPENDENCIES += lines
related to a given option. I.e, the lines:

+OPENCV_DEPENDENCIES += $(if $(BR2_PACKAGE_OPENCV_BUILD_NEW_PYTHON_SUPPORT),python,)

and

+OPENCV_CONF_OPT += -DBUILD_NEW_PYTHON_SUPPORT=$(if $(BR2_PACKAGE_OPENCV_BUILD_NEW_PYTHON_SUPPORT),ON,OFF)

should be next to each other.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list