[Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices

[Sagaert Johan]

Hi

LIBMBUS_AUTORECONF=YES is needed because without it the build yields an
error : 'test/Makefile.in' not found .


-----Oorspronkelijk bericht-----
Van: Luca Ceresoli [mailto:luca at lucaceresoli.net] 
Verzonden: vrijdag 9 december 2011 15:32
Aan: Sagaert Johan
CC: buildroot at busybox.net
Onderwerp: Re: [Buildroot] [PATCH] Add new package libmbus Library for
communicating with energy metering devices

Sagaert Johan wrote:
>
> Signed-off-by: Sagaert Johan<sagaert.johan at skynet.be>
> ---
>   package/Config.in          |    1 +
>   package/libmbus/Config.in  |    7 +++++++
>   package/libmbus/libmbus.mk |   12 ++++++++++++
>   3 files changed, 20 insertions(+), 0 deletions(-)
>   create mode 100644 package/libmbus/Config.in
>   create mode 100644 package/libmbus/libmbus.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index e949649..8f0b5ba 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
>   source "package/neon/Config.in"
>   source "package/libmnl/Config.in"
>   source "package/libmodbus/Config.in"
> +source "package/libmbus/Config.in"
>   source "package/libnl/Config.in"
>   source "package/libpcap/Config.in"
>   source "package/libosip2/Config.in"
> diff --git a/package/libmbus/Config.in b/package/libmbus/Config.in
> new file mode 100644
> index 0000000..93666ed
> --- /dev/null
> +++ b/package/libmbus/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBMBUS
> +	bool "libmbus"
> +	help
> +	  libmbus is a library for communicating with energie metering
devices
> +	  supports TCP and RS232 M-bus gateways.

s/energie/energy/

I'd also reword this way:
   libmbus is a library for communicating with energy metering devices.
   It supports TCP and RS232 M-bus gateways.


> +	
> +	  http://www.freescada.com/libmbus
> diff --git a/package/libmbus/libmbus.mk b/package/libmbus/libmbus.mk
> new file mode 100644
> index 0000000..a57595e
> --- /dev/null
> +++ b/package/libmbus/libmbus.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# libmbus
> +#
> +#############################################################
> +LIBMBUS_VERSION:=0.6.1
> +LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz

This should be removed, as it's equal to Buildroot's default.
Search
for LIBFOO_SOURCE in the docs and you'll read:
   If none are specified, then the value is assumed to be
   packagename-$(LIBFOO_VERSION).tar.gz

> +LIBMBUS_SITE:=http://www.freescada.com/public-dist/
> +LIBMBUS_INSTALL_STAGING=YES
> +LIBMBUS_AUTORECONF=YES

Why is this line needed? The downloaded tarball already contains a
configure script. If there's a specific reason that is not obvious,
then you should add a line of comment.

Luca