[Buildroot] [PATCH] Makefile.package.in: fix upper case $(PKG)_SITE_METHOD

[Daniel Nyström]

011/2/1 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> On Tue,  1 Feb 2011 12:18:49 +0100
> Bjørn Forsman <bjorn.forsman at gmail.com> wrote:
>
>>               case "$($(PKG)_SITE_METHOD)" in \
>> -                     git) $($(DL_MODE)_GIT) && exit ;; \
>> -                     svn) $($(DL_MODE)_SVN) && exit ;; \
>> -                     bzr) $($(DL_MODE)_BZR) && exit ;; \
>> +                     GIT) $($(DL_MODE)_GIT) && exit ;; \
>> +                     SVN) $($(DL_MODE)_SVN) && exit ;; \
>> +                     BZR) $($(DL_MODE)_BZR) && exit ;; \
>>                       *) $(call $(DL_MODE)_WGET,$(1),$(2)) && exit ;; \
>>               esac ; \
>>       fi ; \
>
> No. This is going to break:
>
>        # Try automatic detection using the scheme part of the URI
>        $(2)_SITE_METHOD = $(firstword $(subst ://, ,$(call qstrip,$($(2)_SITE))))
>
> is used to detect the site method from the URI, like :
>
>        git://....
>
> or
>
>        svn://....
>
> so if only upper case site methods are accepted, it's not going to work.
>
> And more generally, I'd prefer to keep the existing lower-case writing
> of the site method, since it is coherent with how it's written in the
> URI.

Maybe, after all, this is a special case where both upper and lower
case should work?