[Buildroot] [PATCH 1/4] Add CMAKETARGETS infrastructure for CMake packages

[Bjørn Forsman]

Hi Thomas,

2011/1/7 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Hello Bjorn,
>
> On Sun, 12 Dec 2010 20:29:12 +0100
> Bjørn Forsman <bjorn.forsman at gmail.com> wrote:
>
>> +# CMake doesn't support having the --sysroot option directly in the
>> +# compiler path, so move this option to the CFLAGS/CXXFLAGS variables.
>> +CMAKE_TARGET_CC = $(filter-out --sysroot=%,$(TARGET_CC))
>> +CMAKE_TARGET_CXX = $(filter-out --sysroot=%,$(TARGET_CXX))
>> +CMAKE_TARGET_CFLAGS = $(filter --sysroot=%,$(TARGET_CC)) $(TARGET_CFLAGS)
>> +CMAKE_TARGET_CXXFLAGS = $(filter --sysroot=%,$(TARGET_CXX)) $(TARGET_CXXFLAGS)
>
> Those definitions should be *outside* the CMAKETARGETS_INNER macro,
> because:
>
>  1/ They might be useful even if no package makes use of the
>    CMAKETARGETS infrastructure
>
>  2/ They are not package specific, so they have no reason to be inside
>    the macro.

You are right. I will fix it in the next version of the patch series.

Best regards,
Bjørn Forsman