[Buildroot] [PATCH 03/13] procps: convert to gentargets and bump to 3.2.8

Peter Korsgaard jacmet at uclibc.org
Mon Jan 17 19:41:28 UTC 2011


>>>>> "Gustavo" == Gustavo Zacarias <gustavo at zacarias.com.ar> writes:

Hi,

 Gustavo> Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
 Gustavo> ---
 Gustavo>  package/procps/procps-make-3.82.patch |   15 ++++++++
 Gustavo>  package/procps/procps.mk              |   61 ++++++++++-----------------------
 Gustavo>  2 files changed, 33 insertions(+), 43 deletions(-)
 Gustavo>  create mode 100644 package/procps/procps-make-3.82.patch

 Gustavo> diff --git a/package/procps/procps-make-3.82.patch b/package/procps/procps-make-3.82.patch
 Gustavo> new file mode 100644
 Gustavo> index 0000000..b66945c
 Gustavo> --- /dev/null
 Gustavo> +++ b/package/procps/procps-make-3.82.patch
 Gustavo> @@ -0,0 +1,15 @@
 Gustavo> +ps/module.mk depends on vars set up in proc/module.mk, so make sure we always
 Gustavo> +include the .mk files in the right order

Please add authorship / signed-off-by to patches. According to the name,
this patch is to fix an issue with make 3.82, but from reading the
description and fix, it doesn't look version dependent?

 Gustavo> +
 Gustavo> +--- procps-3.2.8/Makefile
 Gustavo> ++++ procps-3.2.8/Makefile
 Gustavo> +@@ -174,7 +174,8 @@
 Gustavo> + # want this rule first, use := on ALL, and ALL not filled in yet
 Gustavo> + all: do_all
 Gustavo> + 
 Gustavo> +--include */module.mk
 Gustavo> ++-include proc/module.mk
 Gustavo> ++-include ps/module.mk
 Gustavo> + 
 Gustavo> + do_all:    $(ALL)
 Gustavo> + 

Otherwise looks good.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list