[Buildroot] [PATCH 06/28] package: fix patching procedure for host packages

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Jul 5 07:28:50 UTC 2011


Hello,

Le Tue, 5 Jul 2011 00:01:50 +0200,
"Yann E. MORIN" <yann.morin.1998 at anciens.enib.fr> a écrit :

> I might say something stupid, but what abouta package that is named
> 'foohost-bar'? The 'host-' part will be stripped, and we'd get
> 'foobar'. And that'd be wrong, I think.
> 
> I'd use: $(patsubst host-%,%,$(1))

Ah, good idea, thanks! I've updated my patch with this.

> And even in that case, that does not prevent a target package that
> is named 'host-utils' from matching, and be renamed to just 'utils'.
> 
> But it's been a while I looked at the generic infra, so I might be
> just saying cracks here...

I would say that we don't allow a package to have a name that starts
with "host-". I think even without this patch, having such a package
could cause troubles.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list