[Buildroot] [PATCH 07/28] barebox: re-indent variable definitions

Peter Korsgaard jacmet at uclibc.org
Sun Jul 10 08:57:07 UTC 2011


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

Hi,

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
 Thomas> ---
 Thomas>  boot/barebox/barebox.mk |   13 +++++++------
 Thomas>  1 files changed, 7 insertions(+), 6 deletions(-)

 Thomas> diff --git a/boot/barebox/barebox.mk b/boot/barebox/barebox.mk
 Thomas> index f3e769f..88f222e 100644
 Thomas> --- a/boot/barebox/barebox.mk
 Thomas> +++ b/boot/barebox/barebox.mk
 Thomas> @@ -4,12 +4,13 @@
 Thomas>  #
 Thomas>  #############################################################
 
 Thomas> -BAREBOX_VERSION:=2011.05.0
 Thomas> -BAREBOX_SOURCE:=barebox-$(BAREBOX_VERSION).tar.bz2
 Thomas> -BAREBOX_SITE:=http://www.barebox.org/download/
 Thomas> -BAREBOX_DIR:=$(BUILD_DIR)/barebox-$(BAREBOX_VERSION)
 Thomas> -BAREBOX_CAT:=$(BZCAT)
 Thomas> -BAREBOX_BOARD_DEFCONFIG:=$(call qstrip,$(BR2_TARGET_BAREBOX_BOARD_DEFCONFIG))
 Thomas> +BAREBOX_VERSION := 2011.05.0
 Thomas> +BAREBOX_SOURCE  := barebox-$(BAREBOX_VERSION).tar.bz2
 Thomas> +BAREBOX_SITE    := http://www.barebox.org/download/
 Thomas> +BAREBOX_DIR     := $(BUILD_DIR)/barebox-$(BAREBOX_VERSION)
 Thomas> +BAREBOX_CAT     := $(BZCAT)

I prefer the BAREBOX_CAT = $(BZCAT) style, which is the most commonly
used style under package:

grep -l '[A-Z0-9] = ' package/**/*mk|wc -l
625

grep -l '  = ' package/**/*mk|wc -l
18

grep -l '[A-Z0-9] := ' package/**/*mk|wc -l
7

grep -l '  := ' package/**/*mk|wc -l
0

Care to respin?

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list