[Buildroot] [PATCH] ebtables: new package
Peter Korsgaard
jacmet at uclibc.org
Sun Jul 10 21:08:35 UTC 2011
>>>>> "Baruch" == Baruch Siach <baruch at tkos.co.il> writes:
Baruch> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
Thanks, a few comments:
Baruch> +++ b/package/ebtables/ebtables.mk
Baruch> @@ -0,0 +1,24 @@
Baruch> +#############################################################
Baruch> +#
Baruch> +# ebtables
Baruch> +#
Baruch> +#############################################################
Baruch> +EBTABLES_VERSION = 2.0.9-2
2.0.10-1 is (now) out.
Baruch> +EBTABLES_SOURCE = ebtables-v$(EBTABLES_VERSION).tar.gz
Baruch> +EBTABLES_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/ebtables
Baruch> +
Baruch> +define EBTABLES_BUILD_CMDS
Baruch> + $(MAKE) CC=$(TARGET_CC) LD=$(TARGET_LD) LIBDIR=/lib/ebtables -C $(@D)
You have to add quotes ("") around TARGET_CC / TARGET_LD as
E.G. TARGET_CC is two words when ccache is enabled. You should also set
CFLAGS / LDFLAGS, or even better use TARGET_CONFIGURE_OPTS.
Baruch> +endef
Baruch> +
Baruch> +define EBTABLES_INSTALL_TARGET_CMDS
Baruch> + mkdir -p $(TARGET_DIR)/lib/ebtables
Baruch> + $(INSTALL) -m 0755 -D $(@D)/$(EBTABLES_SUBDIR)/extensions/*.so \
Baruch> + $(TARGET_DIR)/lib/ebtables
Baruch> + $(INSTALL) -m 0755 -D $(@D)/$(EBTABLES_SUBDIR)/*.so \
Baruch> + $(TARGET_DIR)/lib/ebtables
Baruch> + $(INSTALL) -m 0755 -D $(@D)/$(EBTABLES_SUBDIR)/ebtables \
Baruch> + $(TARGET_DIR)/sbin/ebtables
Doesn't the makefile have an install target? You need to provide the
destination file name (not just the dir) when you use install -D.
Uninstall handling would be good as well.
Care to fix and resend?
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list