[Buildroot] [PATCH] dropbear: Create destination directories before use in install stage.

Peter Korsgaard jacmet at uclibc.org
Fri Jul 22 11:34:15 UTC 2011


>>>>> "Quotient" == Quotient Remainder <quotientvremainder at gmail.com> writes:

 Quotient> Signed-off-by: Quotient Remainder <quotientvremainder at gmail.com>

Real name please.

 Quotient> ---
 Quotient>  package/dropbear/dropbear.mk |    1 +
 Quotient>  1 files changed, 1 insertions(+), 0 deletions(-)

 Quotient> diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
 Quotient> index 6ef5dec..2127096 100644
 Quotient> --- a/package/dropbear/dropbear.mk
 Quotient> +++ b/package/dropbear/dropbear.mk
 Quotient> @@ -47,6 +47,7 @@ DROPBEAR_DEPENDENCIES += zlib
 Quotient>  endif
 
 Quotient>  define DROPBEAR_INSTALL_TARGET_CMDS
 Quotient> +	mkdir -p $(TARGET_DIR)/usr/bin $(TARGET_DIR)/usr/sbin
 Quotient>  	$(INSTALL) -m 755 $(@D)/dropbearmulti $(TARGET_DIR)/usr/sbin/dropbear

I would prefer to use install -D like elsewhere to ensure usr/sbin is
created, and then move the mkdir -p just above the _TARGET_BINS loop.

 Quotient>  	for f in $(DROPBEAR_TARGET_BINS); do \
 Quotient>  		ln -snf ../sbin/dropbear $(TARGET_DIR)/usr/bin/$$f ; \
 Quotient> -- 

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list