[Buildroot] Add package statserial

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jun 6 19:21:21 UTC 2011

Hello Francis,

Le Mon, 6 Jun 2011 00:03:36 -0300,
Francis Mendes <francis.mendes at gmail.com> a écrit :

> I needed this package and added it to Buildroot.
> Can anyone review the attached patch for any mistakes?

Thanks for this submission!

It would be nicer to attach the patch inline, as it is easier to make
comments through the patch.

Two comments :

 * You should "select" BR2_PACKAGE_NCURSES instead of "depends on".
   That's the dependency type we use for the dependency of programs on

 * Your statserial-1.1-fixmakefile.patch should have a header with a
   description saying why it is needed, and with a Signed-off-by line.
   From a quick read, I don't see why the patch is needed.

 * Your installation line should be
   $(INSTALL) -D -m 0755 $(@D)/statserial $(TARGET_DIR)/usr/bin/statserial
   otherwise your statserial binary will be named "bin" in
   $(TARGET_DIR)/usr if the usr/bin directory does not exist.

Otherwise, looks good.

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.

More information about the buildroot mailing list