[Buildroot] [PATCH v3] ext-toolchain-wrapper.c: Handle an arbitrary amount of arguments

Mike Frysinger vapier at gentoo.org
Tue Jun 21 21:05:52 UTC 2011


2011/6/21 Daniel Nyström:
> Even though MAXARGS 1000 seems large, it wasn't enought for at least

enought -> enough

> +       cur += sizeof(predef_args) / sizeof(predef_args[0]);

looks like you should add an ARRAY_SIZE define to the top of the file

> +       memcpy(cur, &argv[1], sizeof(char *) * (argc - 1));

in practice there's probably no difference, but this should be sizeof(argv[0])
-mike



More information about the buildroot mailing list