[Buildroot] lockfile-progs depends on liblockfile
yohananov at gmail.com
Tue Mar 8 15:10:06 UTC 2011
It would great if I could send it by my own, but I'm not sure I know what "a
proper patch" looks like.
Do I need to prepare it using git diff as you do, or just diff is enough?
Will the directory structure be kept as in buildroot tree?
a/package/lockfile-progs/lockfile-progs.mk or a/lockfile-progs.mk will be
Could you guide me on it a little bit?
Thank you in advance, Alexander.
On Tue, Mar 8, 2011 at 4:36 PM, Thomas Petazzoni <
thomas.petazzoni at free-electrons.com> wrote:
> Hello Alexander,
> On Tue, 8 Mar 2011 16:22:57 +0200
> Alexander Yohananov <yohananov at gmail.com> wrote:
> > --- a/lockfile-progs.mk 2011-03-08 15:40:51.145037713 +0200
> > +++ b/lockfile-progs.mk 2011-03-08 15:39:35.032038246 +0200
> > @@ -11,6 +11,8 @@
> > $(addprefix lockfile-,check create remove touch) \
> > $(addprefix mail-,lock touchlock unlock)
> > +LOCKFILE_PROGS_DEPENDENCIES = liblockfile
> > +
> > define LOCKFILE_PROGS_BUILD_CMDS
> > $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
> > endef
> Correct. lockfile-progs already selects the liblockfile package in its
> Config.in file, but does not depend on it in its .mk file, which is
> wrong. Your fix is correct.
> > The other possible fix is to add liblockfile to dependencies list in
> > usbmount.mk:
> > USBMOUNT_DEPENDENCIES = udev lockfile-progs liblockfile (I don't know
> > whether the order is important)
> No, that wouldn't work. By doing so, you wouldn't have the guarantee
> that liblockfile is built before lockfile-progs, so the compilation of
> the latter could still fail.
> > The problem exists on buildroot-2010.11, but since buildroot-2011.02
> > contains exactly the same usbmount, lockfile-progs and liblockfile it
> > apparently will appear there as well.
> Yes, this issue hasn't been fixed in the latest version.
> Do you want to send a proper patch so we can keep your attribution, or
> do you want me to send a patch, mentioning your name ?
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> buildroot mailing list
> buildroot at busybox.net
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the buildroot