[Buildroot] [PATCH 1/1] external-toolchain: fix support

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon May 9 06:58:54 UTC 2011


Hello,

On Sun, 08 May 2011 21:59:49 +0200
Peter Korsgaard <jacmet at uclibc.org> wrote:

> The commit would have been a bit smaller if we simply replaced
> TARGET_CC with TOOLCHAIN_EXTERNAL_CC (and same for C++) as we only
> use these macros from ex-tool.mk anyway, but ok.

Yes, but while TARGET_CC can be considered as a global variable, I
don't consider TOOLCHAIN_EXTERNAL_CC to be a global one, but a local
variable to ext-tool.mk (I know 'make' doesn't provide any sort of
variable scoping mechanism, but still). For that reason, I thought that
passing the compiler path was a clearer solution.

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list