[Buildroot] [PATCH 3/3] Makefile.package.in: Fixing git download method

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue May 10 07:36:09 UTC 2011


On Tue, 10 May 2011 09:22:22 +0200
Allan Nielsen <a at awn.dk> wrote:

> When I run buildroot $(DL_DIR) is a relative path which says ./src and
> the current directory (at this point) is $(DL_DIR)/my-git-package/,
> and it will try to place the tar file in
> $(DL_DIR)/my-git-package/src/my-git-package.tar.gz which is the wrong
> place.
> 
> The suggested change should work both when $(DL_DIR) is relative and absolute.

Ah, yes, got it.

> Alternative I could of cause just change my $(DL_DIR) variable to an
> absolute path.

Or, better, make sure that DL_DIR is an absolute path even if it was
defined as a relative path in the configuration. Something like
(untested):

  DL_DIR=$(call qstrip,$(BR2_DL_DIR))
  ifeq ($(DL_DIR),)
  DL_DIR:=$(TOPDIR)/dl
  endif
+ DL_DIR=$(shell readlink -f $(DL_DIR))

in package/Makefile.package.in

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list