[Buildroot] [PATCHv2] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
Baruch Siach
baruch at tkos.co.il
Sun Oct 2 06:22:58 UTC 2011
Hi Buildroot list,
On Mon, Sep 26, 2011 at 10:48:57AM +0300, Baruch Siach wrote:
> The "" string is not equal to the empty string. This fixes build
> errors like:
>
> arm-none-linux-gnueabi-gcc: : No such file or directory
>
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
Ping?
This fixes a real build breakage of the combination of external toolchain and
empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS.
baruch
> ---
> Changes v1 -> v2:
> * Use qstrip as suggested by Thomas Petazzoni
> * Add build failure example to commit log for future reference
>
> toolchain/toolchain-external/ext-tool.mk | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk
> index a357cb9..bf59983 100644
> --- a/toolchain/toolchain-external/ext-tool.mk
> +++ b/toolchain/toolchain-external/ext-tool.mk
> @@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI))
>
> # march/mtune/floating point mode needs to be passed to the external toolchain
> # to select the right multilib variant
> -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> endif
> --
> 1.7.6.3
>
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
More information about the buildroot
mailing list