[Buildroot] [PATCH 01/15] package: show complete URL for external-deps
Peter Korsgaard
jacmet at uclibc.org
Sat Sep 17 06:31:04 UTC 2011
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:
Thomas> The WGET helper that is used for the "make external-deps" target was
Thomas> only showing the filename, and not the complete download URL, which
Thomas> was inconsistent with the SVN, BZR and GIT helpers that all show the
Thomas> complete URL of the upstream project.
Hmm, the uses case for external-deps were:
- What files from the dl/ dir do I need to copy over to new machine to
be able to build this config without internet connectivity?
- What files do I need to archive (next to buildroot) to ensure I can
rebuild this config in years to come?
- What files do I need to provide to customers in addition to buildroot
for GPL compliance?
For all of those the upstream URL isn't really interesting - Perhaps we
should fix the svn/bzr/git helpers instead?
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
Thomas> ---
Thomas> package/Makefile.package.in | 2 +-
Thomas> 1 files changed, 1 insertions(+), 1 deletions(-)
Thomas> diff --git a/package/Makefile.package.in b/package/Makefile.package.in
Thomas> index 868bf28..6dae8f7 100644
Thomas> --- a/package/Makefile.package.in
Thomas> +++ b/package/Makefile.package.in
Thomas> @@ -168,7 +168,7 @@ define SOURCE_CHECK_WGET
Thomas> endef
Thomas> define SHOW_EXTERNAL_DEPS_WGET
Thomas> - echo $(2)
Thomas> + echo $(1)/$(2)
Thomas> endef
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list