[Buildroot] [PATCH] toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS

Baruch Siach baruch at tkos.co.il
Mon Sep 26 07:40:17 UTC 2011


Hi Thomas,

On Mon, Sep 26, 2011 at 09:17:30AM +0200, Thomas Petazzoni wrote:
> Le Mon, 26 Sep 2011 09:46:43 +0300,
> Baruch Siach <baruch at tkos.co.il> a écrit :
> 
> >  # march/mtune/floating point mode needs to be passed to the external toolchain
> >  # to select the right multilib variant
> > -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> > +ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),"")
> >  TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> >  TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> >  endif
> 
> We typically use qstrip for this kind of things:
> 
> TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS))
> ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),)
> TOOLCHAIN_EXTERNAL_CFLAGS += $(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)
> TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
> endif

Thanks for the tip. I'll fix and resend.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the buildroot mailing list