[Buildroot] [PATCH resend] Added protobuf package

Peter Korsgaard jacmet at uclibc.org
Thu Apr 5 17:50:31 UTC 2012


>>>>> "Simon" == Simon Dawson <spdawson at gmail.com> writes:

 Simon> Signed-off-by: Simon Dawson <spdawson at gmail.com>
 Simon> ---
 Simon>  package/Config.in            |    1 +
 Simon>  package/protobuf/Config.in   |    7 +++++++
 Simon>  package/protobuf/protobuf.mk |   17 +++++++++++++++++
 Simon>  3 files changed, 25 insertions(+), 0 deletions(-)
 Simon>  create mode 100644 package/protobuf/Config.in
 Simon>  create mode 100644 package/protobuf/protobuf.mk

 Simon> diff --git a/package/Config.in b/package/Config.in
 Simon> index 36a221c..575373a 100644
 Simon> --- a/package/Config.in
 Simon> +++ b/package/Config.in
 Simon> @@ -388,6 +388,7 @@ source "package/liburcu/Config.in"
 Simon>  source "package/lttng-libust/Config.in"
 Simon>  source "package/orc/Config.in"
 Simon>  source "package/poco/Config.in"
 Simon> +source "package/protobuf/Config.in"
 Simon>  source "package/startup-notification/Config.in"
 Simon>  endmenu

 Simon> diff --git a/package/protobuf/Config.in b/package/protobuf/Config.in
 Simon> new file mode 100644
 Simon> index 0000000..1b0085b
 Simon> --- /dev/null
 Simon> +++ b/package/protobuf/Config.in
 Simon> @@ -0,0 +1,7 @@
 Simon> +config BR2_PACKAGE_PROTOBUF
 Simon> +       bool "protobuf"
 Simon> +       help
 Simon> +         Protocol buffers are Google's language-neutral, platform-neutral,

These lines should be indented with <tab> and not spaces (help lines
with <tab><space><space>)

Protobuf is implemented in C++, so it should depend on
BR2_INSTALL_LIBSTDCPP.

 Simon> +# N.B. Need to use host protoc during cross compilation.
 Simon> +PROTOBUF_DEPENDENCIES = host-protobuf
 Simon> +PROTOBUF_CONF_OPT = --with-protoc=$(HOST_DIR)/usr/bin/protoc
 Simon> +
 Simon> +PROTOBUF_INSTALL_STAGING = YES
 Simon> +

protobuf can use zlib, so we need to ensure it gets built after it if
enabled.

Committed with those fixes, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list