[Buildroot] [PATCH v3 2/2] nodejs: new package
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Sun Aug 12 16:29:09 UTC 2012
Le Sun, 12 Aug 2012 18:52:05 +1000,
Jonathan Liu <net147 at gmail.com> a écrit :
> --- /dev/null
> +++ b/package/nodejs/Config.in
> @@ -0,0 +1,38 @@
> +config BR2_PACKAGE_NODEJS
> + bool "nodejs"
> + help
> + Event-driven I/O server-side JavaScript environment based on V8.
> +
> + http://nodejs.org/
> +
> +if BR2_PACKAGE_NODEJS
> +
> +config BR2_PACKAGE_NODEJS_SSL
> + bool "enable SSL support"
> + default y
> + help
> + Enable SSL support.
In general, we don't add a suboption to enable OpenSSL support: is the
openssl package is enabled, we automatically enable openssl support in
the package.
> +if BR2_PACKAGE_NODEJS_SSL
> +
> +config BR2_PACKAGE_NODEJS_SHARED_OPENSSL
> + bool "use shared OpenSSL"
> + default y
> + select BR2_PACKAGE_OPENSSL
> + help
> + Use shared OpenSSL library instead of statically linked
> + OpenSSL bundled with node.js.
> +
> +endif
I think this should always be the case: use the Buildroot openssl
package if enabled, otherwise disable ssl support. Is there any
advantage to using the built-in version?
> +define NODEJS_CONFIGURE_CMDS
> + (cd $(@D); rm -rf config.cache; \
> + $(TARGET_CONFIGURE_ARGS) \
> + $(TARGET_CONFIGURE_OPTS) \
> + PATH="$(HOST_DIR)/usr/bin:$(PATH)" \
> + ./configure \
> + --prefix=/usr \
> + --without-snapshot \
> + $(if $(BR2_PACKAGE_NODEJS_SHARED_OPENSSL),--shared-openssl,) \
> + $(if $(BR2_PACKAGE_NODEJS_SSL),,--without-ssl) \
> + $(if $(BR2_PACKAGE_NODEJS_NPM),,--without-npm) \
> + $(if $(BR2_PACKAGE_NODEJS_WAF),,--without-waf) \
> + --without-dtrace \
> + --without-etw \
> + )
> +endef
You're using the autotools-package infrastructure, so don't override
the _CONFIGURE_CMDS. You should simply need to do:
NODEJS_CONF_OPT =
--without-snapshot \
$(if $(BR2_PACKAGE_NODEJS_SHARED_OPENSSL),--shared-openssl,) \
$(if $(BR2_PACKAGE_NODEJS_SSL),,--without-ssl) \
$(if $(BR2_PACKAGE_NODEJS_NPM),,--without-npm) \
$(if $(BR2_PACKAGE_NODEJS_WAF),,--without-waf) \
--without-dtrace \
--without-etw
> +NODEJS_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
> +NODEJS_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install
And you can get rid of this as well.
> +define NODEJS_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 775 $(@D)/out/Release/node $(TARGET_DIR)/usr/bin/node
> +endef
> +
> +define NODEJS_UNINSTALL_TARGET_CMDS
> + rm -f $(TARGET_DIR)/usr/bin/node
> +endef
> +
> +$(eval $(autotools-package))
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list