[Buildroot] [PATCH] [PATCH] usb_modeswitch: upgrade to 1.2.3
Thomas De Schampheleire
patrickdepinguin+buildroot at gmail.com
Fri Feb 10 16:41:04 UTC 2012
On Fri, Feb 10, 2012 at 3:28 PM, J.C. Woltz <jwoltz at gmail.com> wrote:
>
> On Fri, Feb 10, 2012 at 2:29 AM, Thomas De Schampheleire
> <patrickdepinguin+buildroot at gmail.com> wrote:
>>
>> Hello,
>>
>> On Fri, Feb 10, 2012 at 12:42 AM, J.C. Woltz <jwoltz at gmail.com> wrote:
>> > From: "J.C. Woltz" <jwoltz at gmail.com>
>> >
>> > Signed-off-by: J.C. Woltz <jwoltz at gmail.com>
>>
>> You shouldn't include a From: line. The Signed-off-by: is the one that
>> should be present.
>>
>
> Will fix.
>
>>
>>
>> > --- a/package/usb_modeswitch/Config.in
>> > +++ b/package/usb_modeswitch/Config.in
>> > @@ -7,3 +7,4 @@ config BR2_PACKAGE_USB_MODESWITCH
>> > Used to switch mode on multiple-function devices
>> >
>> > http://www.draisberghof.de/usb_modeswitch/
>> > +
>>
>> Why is this change needed? I think it should be removed from the patch.
>>
> Will remove, accidental change.
>
>>
>> > diff --git a/package/usb_modeswitch/usb_modeswitch.mk
>> > b/package/usb_modeswitch/usb_modeswitch.mk
>> > index 7b982d8..3d03888 100644
>> > --- a/package/usb_modeswitch/usb_modeswitch.mk
>> > +++ b/package/usb_modeswitch/usb_modeswitch.mk
>> > @@ -4,22 +4,22 @@
>> > #
>> > #############################################################
>> >
>> > -USB_MODESWITCH_VERSION = 1.1.2
>> > +USB_MODESWITCH_VERSION = 1.2.3
>> > USB_MODESWITCH_SOURCE =
>> > usb-modeswitch-$(USB_MODESWITCH_VERSION).tar.bz2
>> > USB_MODESWITCH_SITE = http://www.draisberghof.de/usb_modeswitch
>> > USB_MODESWITCH_DEPENDENCIES = libusb-compat
>> >
>> > define USB_MODESWITCH_BUILD_CMDS
>> > - $(TARGET_CONFIGURE_OPTS) $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
>> > + $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D)
>> > endef
>>
>> Is there a particular reason why you changed this?
>>
>> And to other buildroot developers: what is the policy regarding
>> directly specifying CC and LD, instead of using variables like
>> TARGET_CONFIGURE_OPTS ?
>>
>
> Yes, I changed that line since usb_modeswitch would not compile. I was
> following the example from:
> http://buildroot.uclibc.org/buildroot.html#generic-tutorial
>
> Please let me know how or what you want changed, and I will re-submit.
I checked and this is caused because your Makefile patch removed the
CC ?= gcc
change.
Personally I don't mind your solution, as it is one less change to the
Makefile.
For me, you don't need to change it.
Best regards,
Thomas
More information about the buildroot
mailing list