[Buildroot] [PATCH 1/3 v2] uboot: Add support for U-Boot SPL

[Dechesne, Nicolas]

On Thu, Feb 16, 2012 at 12:57 AM, Arnout Vandecappelle <arnout at mind.be>wrote:

> On Wednesday 15 February 2012 23:04:13 Nicolas Dechesne wrote:
> > SPL is a first stage bootloader. On pandaboard it supercedes x-loader,
> > and should now be used.
> >
> > This patch ensures that either SPL or xloader can be selected
> >
> > Signed-off-by: Nicolas Dechesne <n-dechesne at ti.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
>

thx.


>
> > ---
> >  boot/uboot/Config.in |    6 ++++++
> >  boot/uboot/uboot.mk  |    2 ++
> >  2 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> > index c8db9fb..3661407 100644
> > --- a/boot/uboot/Config.in
> > +++ b/boot/uboot/Config.in
> > @@ -137,4 +137,10 @@ config BR2_TARGET_UBOOT_ETH1ADDR
> >
> >  endif # BR2_TARGET_UBOOT_NETWORK
> >
> > +config BR2_TARGET_UBOOT_SPL
> > +     bool "U-Boot SPL support"
> > +     depends on !BR2_TARGET_XLOADER
> > +     help
> > +       Enable the U-Boot SPL support
>
>  The help text could be a bit more verbose.  E.g. explain what SPL stands
> for.  At least mention that the SPL binary is called MLO (the logic of
> which escapes me :-)
>

ok. I will update and resend. i will give a few more days to get more
reviews, just in case...

by the way, about the MLO stuff ... it comes from the OMAP romcode. this is
where the name 'MLO' is hardcoded. when booting from SD/eMMC formated with
FAT the ROM code will parse the FAT table and search for a file named MLO,
which stands for 'Memory LOader'. Such a boot mechanism is indeed what we
call memory booting as opposed to peripheral boot when we boot from USB or
UART. so MLO name has nothing to do with SPL, which is a uboot terminology
(Second Program Loader).


> > +
> >  endif # BR2_TARGET_UBOOT
> > diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> > index db9de8d..41745c9 100644
> > --- a/boot/uboot/uboot.mk
> > +++ b/boot/uboot/uboot.mk
> > @@ -88,6 +88,8 @@ endef
> >
> >  define UBOOT_INSTALL_IMAGES_CMDS
> >       cp -dpf $(@D)/$(UBOOT_BIN) $(BINARIES_DIR)/
> > +     $(if $(BR2_TARGET_UBOOT_SPL),
> > +             cp -dpf $(@D)/MLO $(BINARIES_DIR)/)
> >  endef
>
>  I didn't know it was possible to split functions over several lines
> without \.  Nice to know!
>
>  Regards,
>  Arnout
>
> --
> Arnout Vandecappelle                               arnout at mind be
> Senior Embedded Software Architect                 +32-16-286540
> Essensium/Mind                                     http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR
> Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120216/bde9ed1a/attachment-0002.html>