[Buildroot] [PATCH v5 1/2] usb_modeswitch: update to 1.2.3

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jul 15 21:12:23 UTC 2012


Hello,

[ Reviving an old thread... ]

Le Sat, 17 Mar 2012 21:30:34 -0400,
"J.C. Woltz" <jwoltz at gmail.com> a écrit :

> This patch updates usb_modeswitch to version 1.2.3.
> The usb_modeswitch.mk needed to be modified for usb_modeswitch to compile.
> Also added extra remove section for the added help scripts and files.
> 
> Signed-off-by: J.C. Woltz <jwoltz at gmail.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
> replace TARGET_MAKE_ENV and add USB_MODESWITCH_UNINSTALL_CMDS
> as recommended by Arnout Vandecappelle

Why do you use TARGET_MAKE_ENV here? It seems much better to use
TARGET_CONFIGURE_OPTS as you were doing in previous versions of your
patch. Arnout, can you explain why you suggested using TARGET_MAKE_ENV
instead of TARGET_CONFIGURE_OPTS?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com


More information about the buildroot mailing list