[Buildroot] [PATCH] New package: cJSON (v2)

Danomi Manchego danomimanchego123 at gmail.com
Tue Jun 12 00:03:38 UTC 2012


Peter,

> I'm not sure it makes sense to build a .so of something as simple (and
> unversioned) as this. How about just doing a static .a like ezxml?

We use cJSON in about half a dozen apps in our project, so a .so seemed
like the way to go.  If you feel strongly about this, would you be open to
having an option to make a shared object?  (Maybe something like the
logic in zlib.mk or qt.mk.)

> You also shouldn't hardcode compiler flags like -Wall / -O2 but use
> $(TARGET_CFLAGS) instead - E.G.

Understood, will adjust.

> You should also install the header file into TARGET_DIR. It will get
> removed by target-finalize if it isn't needed.

Ah, I didn't know that.  Nice!

> Care to fix and resend?

Certainly - after hearing your feedback on the .so/.a question.

Danomi -
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120611/9411f836/attachment-0002.html>


More information about the buildroot mailing list