[Buildroot] [PATCH v2] ushare: new package
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed Mar 21 13:44:52 UTC 2012
Le Wed, 21 Mar 2012 10:39:35 -0300,
Gustavo Zacarias <gustavo at zacarias.com.ar> a écrit :
> > With GENTARGETS, xxx_BUILD_CMDS is empty by default. Are you sure
> > this
> > builds?
>
> Yes, install triggers build.
But still, build should be done in the xxx_BUILD_CMDS so that it works
like all other packages, IMO.
> > Also, can you add a comment just before USHARE_CONFIGURE_CMDS saying
> > that despite the appearance, autotools are not used. However, I am
> > sure
> > in the future many people will wonder why AUTOTARGETS was not used.
>
> Sure, but should it be for other packages as well?
Yes, I think we should mention explicitly why GENTARGETS is used even
though the package has a ./configure script.
> Same things applies to ffmpeg and probably others (the ushare configure
> is an old/strip version from ffmpeg).
> Though ffmpeg is using AUTOTARGETS and overriding CONFIGURE_CMDS...
And it is wrong. Not your fault, of course, but I don't think it is an
argument to make it wrong in other places as well.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the buildroot
mailing list