[Buildroot] [PATCH 1/3] Convert gettext to autotargets

Samuel Martin s.martin49 at gmail.com
Mon May 21 07:52:05 UTC 2012


Hi,

2012/5/19 Peter Korsgaard <jacmet at uclibc.org>:
>>>>>> "Samuel" == Samuel Martin <s.martin49 at gmail.com> writes:
>
> Hi,
>
>  Samuel> From: Maxime Ripard <maxime.ripard at free-electrons.com>
>  Samuel> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>  Samuel> Acked-by: Samuel Martin <s.martin49 at gmail.com>
>  Samuel> ---
>
>  Samuel> -$(GETTEXT_DIR)/$(GETTEXT_BINARY): $(GETTEXT_DIR)/.configured
>  Samuel> -      $(MAKE) -C $(GETTEXT_DIR)
>  Samuel> -      touch -c $(GETTEXT_DIR)/$(GETTEXT_BINARY)
>  Samuel> +define GETTEXT_REMOVE_BINARIES
>  Samuel> +      rm -f $(TARGET_DIR)/usr/bin/gettext
>  Samuel> +      rm -f $(TARGET_DIR)/usr/bin/gettext.sh
>  Samuel> +      rm -f $(TARGET_DIR)/usr/bin/gettextize
>  Samuel> +endef
>
>  Samuel>  ifeq ($(BR2_PACKAGE_LIBINTL),y)
>  Samuel> +      GETTEXT_POST_INSTALL_TARGET_HOOKS += GETTEXT_REMOVE_BINARIES
>  Samuel>  endif
>  Samuel> +
>
> This seems backwards. Wouldn't you want to keep the binaries if libintl
> is enabled?

Actually, do we really need to remove these binaries?
On an arm build, these 3 binaries take less than 80KB.

Cheers,

Sam



More information about the buildroot mailing list