[Buildroot] [PATCHv3] QtSerialPort: new package

Thiago A. Corrêa thiago.correa at gmail.com
Mon Nov 5 13:37:45 UTC 2012


Hi Peter,

On Sat, Nov 3, 2012 at 2:46 PM, Peter Korsgaard <jacmet at uclibc.org> wrote:
>
> Thomas a while ago posted patches for qtextserialport:
>
> http://patchwork.ozlabs.org/patch/162431/
>
> What is the relation between qtserialport and qtextserialport? Do we
> need both?

I'm not sure if there is a relation between the two, but qtserialport
(this package) is under the Qt Project umbrella (Repository, Gerrit
code review, CI Servers/Tests). Currently it's under the playground
repository but it has already been voted for graduation from
playground on the development mailing list. Should be an "official"
addon soon.

>  Thiago> +define QTSERIALPORT_INSTALL_STAGING_CMDS
>  Thiago> +      $(MAKE) -C $(@D)/src install
>  Thiago> +      mv $(HOST_DIR)/usr/include/QtAddOnSerialPort $(STAGING_DIR)/usr/include/
>
> That seems funky. Why is it installing under HOST_DIR in the first
> place?

Beats me :(
The makefile generated by qmake is installing them there. Haven't
found a better way to fix that so far.

>  Thiago> +endef
>  Thiago> +
>  Thiago> +define QTSERIALPORT_INSTALL_TARGET_CMDS
>  Thiago> +      cp -dpfr $(STAGING_DIR)/usr/lib/libSerialPort.so.* \
>  Thiago> +      $(TARGET_DIR)/usr/lib
>
> Normally we install headers to target as well. Does the makefile install
> target not support DESTDIR?
>

Unfortunally, no.
Shouldn't the headers be installed to target only if the target has a
compiler? Or should I copy there unconditionally?

Kind Regards,
    Thiago A. Correa



More information about the buildroot mailing list