[Buildroot] [PATCH 1/2] neard: new package

Simon Dawson spdawson at gmail.com
Fri Nov 9 13:36:09 UTC 2012


Hi Thomas; thanks for the feedback.

On 9 November 2012 13:20, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
>
> > +     depends on BR2_LINUX_KERNEL
>
> Why this dependency?

You're right; this is superfluous.

> > +     help
> > +       Near Field Communication (NFC) manager
>
> A slightly longer description would be useful here.

Okay.

> > +       https://01.org/linux-nfc/documentation/how-start-linux-nfc-code...
>
> Those "..." at the end look strange.

Yes, they do look strange; but this is correct --- the dots are a
required part of the URL.

> > +NEARD_AUTORECONF = YES
>
> The package does not have any patches, and is downloaded from a
> tarball. Why is an autoreconf needed?

The autoreconf is not needed; thanks for pointing this out.

I'll rework the patch.

Simon.



More information about the buildroot mailing list