[Buildroot] [PATCH 1/5] arch: improve definition of gcc mtune, mcpu, etc.

[Thomas Petazzoni]

On Thu, 15 Nov 2012 14:38:30 +0100, Yann E. MORIN wrote:

> I know you are just moving stuff around, but those symbols are typed
> as strings, so the default values should be enclosed in-between double
> quotes:
>     default "arm600"   if BR2_arm600
> 
> Moreover, the code is not coherent with itslef, even in a single file.
> For example, you have (both are string symbols):
> 
>     config BR2_ENDIAN
>         default "LITTLE" if BR2_arm
> 
>     config BR2_GCC_TARGET_TUNE
>         default arm600   if BR2_arm600
> 
> That it currently works is just happenstance, and may well break in
> the future when we upgrade to a newer kconfig version.
> 
> Maybe we can just apply this for now, and fix that in a future patch?

I sent a new pull request, which includes a patch fixing this problem.
Thanks for reminding me about it!

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com