[Buildroot] [PATCH] manual: minor tweaks

Samuel Martin s.martin49 at gmail.com
Fri Nov 16 14:35:00 UTC 2012


2012/11/16 Simon Dawson <spdawson at gmail.com>:
> On 16 November 2012 12:55, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
>> Please find my comments below.
>
> Hi Yann; thanks for the feedback.
>
>>> diff --git a/docs/manual/how-buildroot-works.txt b/docs/manual/how-buildroot-works.txt
>>> index 879cff3..31774c0 100644
>>> --- a/docs/manual/how-buildroot-works.txt
>>> +++ b/docs/manual/how-buildroot-works.txt
>>> @@ -9,7 +9,7 @@ also includes patches for various software packages - mainly the ones
>>>  involved in the cross-compilation tool chain (+gcc+, +binutils+ and
>>>  +uClibc+).
>>>
>>> -There is basically one Makefile per software package, and they are
>>> +There is basically one Makefile for each software package, and they are
>>
>> Why? 'per' is perfectly legit in this context.
>
> I tend to avoid the Latin "per" habitually in my writing, because of
> previous bad experiences with (human) translators. But I don't feel
> strongly about it, so let's leave it in here.
>
>>> diff --git a/docs/manual/writing-rules.txt b/docs/manual/writing-rules.txt
>>> index e0a5a2a..c32f855 100644
>>> --- a/docs/manual/writing-rules.txt
>>> +++ b/docs/manual/writing-rules.txt
>>> @@ -3,7 +3,7 @@
>>>  Writing rules
>>>  -------------
>>>
>>> -Overall, those writing rules are here to help you add new files in
>>> +Overall, these writing rules are here to help you add new files in
>>
>> Proper use of 'these' in this case! ;-)
>
> Well, either "those" refers to "those people" here --- in which case
> it is correct --- or else the reference is to the rules themselves. It
> is not completely clear to me from the context which sense is
> intended, but I assume that it is the rules themselves that are
> referred to.
I confirm, here "these" refers to the rules themselves.

>
>> When you have addressed these changes, you can add my:
(the same for me)
>>   - Acked-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
Acked-by: Samuel Martin <s.martin49 at gmail.com>


Regards,

-- 
Sam



More information about the buildroot mailing list