[Buildroot] [PATCH 03/33] tcpdump: use 'pkg-config pcap' instead of pcap-config

Samuel Martin s.martin49 at gmail.com
Thu Nov 22 10:46:33 UTC 2012


Hi Thomas,

2012/11/22 Thomas Petazzoni <thomas.petazzoni at free-electrons.com>:
> Dear Samuel Martin,
>
> On Thu, 22 Nov 2012 01:17:53 +0100, Samuel Martin wrote:
>
>> +-        AC_PATH_TOOL(PCAP_CONFIG, pcap-config)
>> ++        AC_PATH_TOOL(PCAP_CONFIG, pkg-config)
>
> This is not generally how pkg-config is used. In general, people use
> the PKG_CHECK_MODULES() autoconf macro.
>
> Has this been pushed upstream?
I've not tried to push this patch upstream yet.

> I guess you need to make it smarter
> like: start testing with pkg-config, then fallback to pcap-config, in
> order to make this suitable for upstream.
I agree.
The truth is I'm not so confident with autotools, so any enlightment is welcome.


Regards,


-- 
Sam



More information about the buildroot mailing list