[Buildroot] [PATCH v3 1/6] snowball-hdmiservice: new package

[Arnout Vandecappelle]

On 22/11/12 13:35, Grégory Hermant wrote:
> Arnout,
> Le 21/11/2012 07:51, Arnout Vandecappelle a écrit :
>> On 15/11/12 09:25, Gregory Hermant wrote:
>>>
>>> Signed-off-by: Gregory Hermant<gregory.hermant at calao-systems.com>
>> [snip]
>>> +
>>> +define SNOWBALL_HDMISERVICE_BUILD_CMDS
>>> +    $(MAKE) CC="$(TARGET_CC)" -C $(@D)
>>> +endef
>>
>>   I may have asked this before, but is there a reason to not pass buildroot's
>> CFLAGS and LDFLAGS?  We usually pass $(TARGET_CONFIGURE_OPTS) to sub-makes.
>>
>> [snip]
>>
> The build of the hdmiservice.so fails if i pass the buildroot's LDFLAGS.

  It should be passed in the environment, not in the make argument list.
Otherwise it will override the definition in the Makefile itself.

  A good Makefile appends to LDFLAGS passed in from the environment, but this
is not always the case...  Anyway the worst that can happen is that the LDFLAGS
are just ignored.

  Regards,
  Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F