[Buildroot] [PATCH] flex: fix build for nommu systems

Gustavo Zacarias gustavo at zacarias.com.ar
Fri Nov 30 10:36:00 UTC 2012


On 11/29/2012 08:19 PM, Arnout Vandecappelle wrote:
>  Two small comments.
> 
> [snip]
>> +ifeq ($(BR2_PACKAGE_FLEX_BINARY),)
> 
>  I would prefer to compare with y and swap the two branches
> (that will also make the diff much more readable...)

Sure, i left it that way because i was using another aproach before this
one (removing the binary option since it's pointless without a target
toolchain), but changed my mind after a little chat with Thomas.

>> +define FLEX_DISABLE_PROGRAM
>> +    $(SED) 's/^bin_PROGRAMS.*//' $(@D)/Makefile.in
>>   endef
>>
>> -define FLEX_UNINSTALL_LEX
>> -    -rm $(TARGET_DIR)/usr/bin/lex
>> -endef
>> +FLEX_POST_EXTRACT_HOOKS += FLEX_DISABLE_PROGRAM
> 
>  POST_PATCH_HOOKS would be more appropriate.

Really?
It's basically another patch, i can do it before (like now) it's patched
with something else or after.
If the other patches did too much damage so that the sed wouldn't work,
well, it'd probably be against buildroot policy on patches :)
Regards.




More information about the buildroot mailing list