[Buildroot] [PATCH 1/4] If linux-pam is built, enable dbm functionality in Berkeley DB

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Sep 11 14:32:08 UTC 2012


Le Sat,  8 Sep 2012 00:21:03 -0400,
Dmitry <golubovsky at gmail.com> a écrit :

> +		$(if $(BR2_PACKAGE_LINUX_PAM),--enable-dbm,--disable-dbm) \

I don't really like this. I think you should rather add a configuration
sub-option in package/berkeleydb/Config.in to enable/disable DBM
support, and then have berkeleydb.mk test this configuration option,
and the linux-pam/Config.in package select it.

I don't like when one package recipe pokes into the configuration
options of another package.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the buildroot mailing list